text: Remove layout line & layout box interior bounds #18476
Merged
+12
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
added
text
adrian17
approved these changes
Nov 4, 2024
torokati44
force-pushed
the
interior-bounds
branch
from
937b2fd
to
52d2269
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were originally used for some calculations, but now they have been replaced by proper bounds.
When reworking the layout, I added proper bounds (named
bounds), and renamed the original bounds tointerior_boundsin order to preserve the old behavior in some places. As of now, we're ready to drop the interior bounds, as replacing them with proper bounds works and all tests pass.Areas where this PR changes the calculated values (by a bit):