extension: Manifest v3 first draft - works minimally on FF, not Chrome #9356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will close immediately, since this does not work. Meant to help exemplify what is needed for Manifest V3.
Issues on Firefox: Extension does not activate until Ruffle symbol is clicked (maybe just because it's an unsigned add-on with a modified manifest though); opening an SWF in a new tab does not work (maybe because the persistent keyword no longer works).
Issues on Chrome: Does not work in the current form. Chrome should use
declarativeNetRequest
instead ofwebRequestBlocking
(does not work on Firefox). Chrome should use"service_worker": "dist/background.js"
instead of"scripts": ["dist/background.js"]
(does not work on Firefox). With those two changes, I still run into https://stackoverflow.com/questions/70474845/inject-javascript-from-content-script-with-a-chrome-extension-v3 and failure of dist/background.js to register as a service worker (due to errors such asdocument is not defined
), but some sites do work. However, sites that do checks for Adobe Flash Player don't detect Ruffle.