Add test

rui-mo · Apr 9, 2024 · 9bba056 · 9bba056
1 parent 650eb6a
commit 9bba056
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/velox/functions/prestosql/DecimalFunctions.cpp b/velox/functions/prestosql/DecimalFunctions.cpp
@@ -363,6 +363,7 @@ void registerDecimalMultiply(const std::string& prefix) {
           exec::ParameterType::kIntegerParameter),
       exec::SignatureVariable(
           S3::name(),
+          // Result type resolution fails if sum of input scales exceeds 38.
           fmt::format(
               "{a_scale} + {b_scale}",
               fmt::arg("a_scale", S1::name()),

diff --git a/velox/functions/prestosql/tests/DecimalArithmeticTest.cpp b/velox/functions/prestosql/tests/DecimalArithmeticTest.cpp
@@ -291,6 +291,14 @@ TEST_F(DecimalArithmeticTest, multiply) {
                   HugeInt::build(0x08FFFFFFFFFFFFFF, 0xFFFFFFFFFFFFFFFF)},
               DECIMAL(38, 0))}),
       "Decimal overflow. Value '119630519620642428561342635425231011830' is not in the range of Decimal Type");
+
+  // The sum of input scales exceeds result precision.
+  VELOX_ASSERT_THROW(
+      evaluate(
+          "c0 * c0",
+          makeRowVector(
+              {makeFlatVector<int128_t>({1000, 2000}, DECIMAL(38, 30))})),
+      "");
 }
 
 TEST_F(DecimalArithmeticTest, decimalDivTest) {