Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement space summary API #953

Merged
merged 2 commits into from
Mar 1, 2022
Merged

Implement space summary API #953

merged 2 commits into from
Mar 1, 2022

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented Feb 25, 2022

Both in client-api and federation-api.

According to MSC2946.
Closes #863.

jplatte
jplatte reviewed Mar 1, 2022
View reviewed changes
crates/ruma-client-api/src/space/get_hierarchy.rs Outdated Show resolved Hide resolved
crates/ruma-client-api/src/space/get_hierarchy.rs Show resolved Hide resolved
crates/ruma-events/src/space/child.rs Outdated Show resolved Hide resolved
crates/ruma-federation-api/src/space.rs Outdated Show resolved Hide resolved
crates/ruma-federation-api/src/space.rs Outdated Show resolved Hide resolved
@zecakeh zecakeh requested a review from a team March 1, 2022 14:50
@jplatte
Copy link
Member

jplatte commented Mar 1, 2022

Can you rebase and squash the review-response commits into the other ones?

@jplatte jplatte merged commit c52e51c into main Mar 1, 2022
@jplatte jplatte deleted the zecakeh/space-summary branch March 1, 2022 15:36
@zecakeh zecakeh mentioned this pull request Mar 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte jplatte approved these changes

@DevinR528 DevinR528 Awaiting requested review from DevinR528

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add space summary API (MSC2946)
2 participants
@zecakeh @jplatte