Raspawar/add vlm support #16751
Open
Raspawar/add vlm support #16751
+2,392
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
dosubot
bot
added
size:XXL
mattf
suggested changes
Oct 30, 2024
There was a problem hiding this comment.
please address comments.
failing tests -
FAILED tests/test_multi_modal_nvidia.py::test_vlm_asset_id[invoke-content0-microsoft/phi-3-vision-128k-instruct] - TypeError: sequence item 0: expected str instance, function found
FAILED tests/test_multi_modal_nvidia.py::test_vlm_asset_id[stream-content0-microsoft/phi-3-vision-128k-instruct] - TypeError: sequence item 0: expected str instance, function found
...i_modal_llms/llama-index-multi-modal-llms-nvidia/llama_index/multi_modal_llms/nvidia/base.py
Outdated
Show resolved
Hide resolved
...i_modal_llms/llama-index-multi-modal-llms-nvidia/llama_index/multi_modal_llms/nvidia/base.py
Outdated
Show resolved
Hide resolved
...i_modal_llms/llama-index-multi-modal-llms-nvidia/llama_index/multi_modal_llms/nvidia/base.py
Outdated
Show resolved
Hide resolved
...i_modal_llms/llama-index-multi-modal-llms-nvidia/llama_index/multi_modal_llms/nvidia/base.py
Outdated
Show resolved
Hide resolved
...i_modal_llms/llama-index-multi-modal-llms-nvidia/llama_index/multi_modal_llms/nvidia/base.py
Outdated
Show resolved
Hide resolved
...i_modal_llms/llama-index-multi-modal-llms-nvidia/llama_index/multi_modal_llms/nvidia/base.py
Outdated
Show resolved
Hide resolved
...i_modal_llms/llama-index-multi-modal-llms-nvidia/llama_index/multi_modal_llms/nvidia/base.py
Outdated
Show resolved
Hide resolved
...i_modal_llms/llama-index-multi-modal-llms-nvidia/llama_index/multi_modal_llms/nvidia/base.py
Outdated
Show resolved
Hide resolved
...i_modal_llms/llama-index-multi-modal-llms-nvidia/llama_index/multi_modal_llms/nvidia/base.py
Outdated
Show resolved
Hide resolved
...i_modal_llms/llama-index-multi-modal-llms-nvidia/llama_index/multi_modal_llms/nvidia/base.py
Show resolved
Hide resolved
mattf
suggested changes
Nov 5, 2024
...i_modal_llms/llama-index-multi-modal-llms-nvidia/llama_index/multi_modal_llms/nvidia/base.py
Show resolved
Hide resolved
...i_modal_llms/llama-index-multi-modal-llms-nvidia/llama_index/multi_modal_llms/nvidia/base.py
Outdated
Show resolved
Hide resolved
...i_modal_llms/llama-index-multi-modal-llms-nvidia/llama_index/multi_modal_llms/nvidia/base.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
tbh the way cicd works, including extra files like this is a huge pain
I would just create an image in-memory -- like a black or white square. Or download the images at runtime
|
@logan-markewich can u ptal. I donno why the coverage is considering the test cases also. |
There was a problem hiding this comment.
Can we have an actual readme? Something with the install command and general usage (probably similar to the notebook)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for vision-language models, those that can accept images and text as input and produce text.
these are akin to https://platform.openai.com/docs/guides/vision with three notable differences -
not all model endpoints support all features, e.g. server-side download of images not available with
adept/fuyu-8b, google/deplot, microsoft/kosmos-2, google/paligemma; some models endpoints restrict image size; some models support one and only image; some models do not support gif or webp; kosmos-2 does not support streaming
cc: @sumitkbh @mattf @dglogo