Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tenacity depends confilct with GraphRAG: llama-index-core(<9.0.0) and GraphRAG(>=9.0.0) #16875

Closed
wants to merge 1 commit into from

Conversation

eriklee1895
Copy link

Description

When my project use llama-index and GraphRAG, there is a tenacity depends:

The conflict is caused by:
    graphrag 0.4.0 depends on tenacity<10.0.0 and >=9.0.0
    llama-index-core 0.11.22 depends on tenacity!=8.4.0, <9.0.0 and >=8.2.0

Here are the release notes for tenacity 9 (https://github.com/jd/tenacity/releases/tag/9.0.0)
And I found langchain has already updated tenacity version:
langchain-ai/langchain#27201

Now, I wish llama-index can do the same change.

Fixes # (issue)
This should fixes the compatibility issue with graprag as in:
microsoft/graphrag#929

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Fix depends version conflict.

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

update tenacity depends version to fix conflict with GraphRAG
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 8, 2024
@eriklee1895 eriklee1895 closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant