Atlantis e2e tests for policy checks step (#42)

* Adding e2e tests for policy checks.

Added project lock for policy approval step.
Moved policy approval into a DefaultProjectCommandRunner

* Fixing these cursed tests

* Adding conftest0.21.0 binary check

* Deleting unused fixtures

* Remove print statement

server/events/approve_policies_command_runner.go

@@ -9,7 +9,7 @@ import (
 func NewApprovePoliciesCommandRunner(
 	commitStatusUpdater CommitStatusUpdater,
 	prjCommandBuilder ProjectApprovePoliciesCommandBuilder,
-	prjCommandRunner ProjectPolicyCheckCommandRunner,
+	prjCommandRunner ProjectApprovePoliciesCommandRunner,
 	pullUpdater *PullUpdater,
 	dbUpdater *DBUpdater,
 ) *ApprovePoliciesCommandRunner {
@@ -27,7 +27,7 @@ type ApprovePoliciesCommandRunner struct {
 	pullUpdater         *PullUpdater
 	dbUpdater           *DBUpdater
 	prjCmdBuilder       ProjectApprovePoliciesCommandBuilder
-	prjCmdRunner        ProjectPolicyCheckCommandRunner
+	prjCmdRunner        ProjectApprovePoliciesCommandRunner
 }
 
 func (a *ApprovePoliciesCommandRunner) Run(ctx *CommandContext, cmd *CommentCommand) {
@@ -76,16 +76,7 @@ func (a *ApprovePoliciesCommandRunner) buildApprovePolicyCommandResults(ctx *Com
 	var prjResults []models.ProjectResult
 
 	for _, prjCmd := range prjCmds {
-
-		prjResult := models.ProjectResult{
-			Command: models.PolicyCheckCommand,
-			PolicyCheckSuccess: &models.PolicyCheckSuccess{
-				PolicyCheckOutput: "Policies approved",
-			},
-			RepoRelDir:  prjCmd.RepoRelDir,
-			Workspace:   prjCmd.Workspace,
-			ProjectName: prjCmd.ProjectName,
-		}
+		prjResult := a.prjCmdRunner.ApprovePolicies(prjCmd)
 		prjResults = append(prjResults, prjResult)
 	}
 	result.ProjectResults = prjResults

server/events/command_runner_test.go

@@ -497,6 +497,15 @@ func TestApprovedPoliciesUpdateFailedPolicyStatus(t *testing.T) {
 		},
 	}, nil)
 
+	When(projectCommandRunner.ApprovePolicies(matchers.AnyModelsProjectCommandContext())).Then(func(_ []Param) ReturnValues {
+		return ReturnValues{
+			models.ProjectResult{
+				Command:            models.PolicyCheckCommand,
+				PolicyCheckSuccess: &models.PolicyCheckSuccess{},
+			},
+		}
+	})
+
 	When(workingDir.GetPullDir(fixtures.GithubRepo, fixtures.Pull)).ThenReturn(tmp, nil)
 
 	ch.RunCommentCommand(fixtures.GithubRepo, &fixtures.GithubRepo, &fixtures.Pull, fixtures.User, fixtures.Pull.Num, &events.CommentCommand{Name: models.ApprovePoliciesCommand})

server/events/project_command_runner.go

@@ -95,12 +95,18 @@ type ProjectPolicyCheckCommandRunner interface {
 	PolicyCheck(ctx models.ProjectCommandContext) models.ProjectResult
 }
 
+type ProjectApprovePoliciesCommandRunner interface {
+	// Approves any failing OPA policies.
+	ApprovePolicies(ctx models.ProjectCommandContext) models.ProjectResult
+}
+
 // ProjectCommandRunner runs project commands. A project command is a command
 // for a specific TF project.
 type ProjectCommandRunner interface {
 	ProjectPlanCommandRunner
 	ProjectApplyCommandRunner
 	ProjectPolicyCheckCommandRunner
+	ProjectApprovePoliciesCommandRunner
 }
 
 // DefaultProjectCommandRunner implements ProjectCommandRunner.
@@ -162,6 +168,36 @@ func (p *DefaultProjectCommandRunner) Apply(ctx models.ProjectCommandContext) mo
 	}
 }
 
+func (p *DefaultProjectCommandRunner) ApprovePolicies(ctx models.ProjectCommandContext) models.ProjectResult {
+	approvedOut, failure, err := p.doApprovePolicies(ctx)
+	return models.ProjectResult{
+		Command:            models.PolicyCheckCommand,
+		Failure:            failure,
+		Error:              err,
+		PolicyCheckSuccess: approvedOut,
+		RepoRelDir:         ctx.RepoRelDir,
+		Workspace:          ctx.Workspace,
+		ProjectName:        ctx.ProjectName,
+	}
+}
+
+func (p *DefaultProjectCommandRunner) doApprovePolicies(ctx models.ProjectCommandContext) (*models.PolicyCheckSuccess, string, error) {
+	// Acquire Atlantis lock for this repo/dir/workspace.
+	lockAttempt, err := p.Locker.TryLock(ctx.Log, ctx.Pull, ctx.User, ctx.Workspace, models.NewProject(ctx.Pull.BaseRepo.FullName, ctx.RepoRelDir))
+	if err != nil {
+		return nil, "", errors.Wrap(err, "acquiring lock")
+	}
+	if !lockAttempt.LockAcquired {
+		return nil, lockAttempt.LockFailureReason, nil
+	}
+	ctx.Log.Debug("acquired lock for project")
+
+	return &models.PolicyCheckSuccess{
+		LockURL:           p.LockURLGenerator.GenerateLockURL(lockAttempt.LockKey),
+		PolicyCheckOutput: "Policies approved",
+	}, "", nil
+}
+
 func (p *DefaultProjectCommandRunner) doPolicyCheck(ctx models.ProjectCommandContext) (*models.PolicyCheckSuccess, string, error) {
 	// Acquire Atlantis lock for this repo/dir/workspace.
 	lockAttempt, err := p.Locker.TryLock(ctx.Log, ctx.Pull, ctx.User, ctx.Workspace, models.NewProject(ctx.Pull.BaseRepo.FullName, ctx.RepoRelDir))