Can we disable the new 0.25.0 behavior around reporting things as applied when there are no changes? #3793
-
|
This is specifically proving to be an issue with using Atlantis in Bitbucket Cloud because Bitbucket Cloud is the slow stepchild of a pair of knuckle-dragging hominids from a billion years ago. See: Bitbucket Cloud has only one branch restriction rule for ensuring builds pass AND there are no active builds. It's a silly compound rule that's all or nothing.
We're using renovatebot to manage provider versions and it can open big PR that are mostly no-op plans for the projects in our Terraform repo. Mostly. Save for maybe 1-2 plans that claim to be drifted because something like an auto-expanding disk on a DB was updated by the cloud vendor and the Terraform wasn't written entirely correctly to ignore the fact that this can change dynamically. Prior to 0.25.0 we'd get two sign-offs on these PRs and we'd merge without applying. But with 0.25.0 this change blocks our ability to do that because Atlantis reports the apply step as being in-progress. All the no-op plans being reported as applies. 
That top check, being blue now, prevents merge from ever becoming available for the PR. We can "cheat", of course, and temporarily disable that branch restriction on the repo. But that can have consequences in the future with some regulatory stuff we try to stay on the up and up with. Is it possible to disable this feature on an installation basis? I didn't see anything in the code, but figured asking couldn't hurt. I know. I know. The answer is really to kick Bitbucket Cloud to the curb in favor of a DSCC that doesn't...well...suck. But that's not really feasible for me right now. |
Beta Was this translation helpful? Give feedback.
Replies: 8 comments 1 reply
-
|
I do not think this was added behind a flag, it can be but code changes will be required. |
Beta Was this translation helpful? Give feedback.
-
|
Hi @ianchesal, It is likely that this is resolved by #3747. |
Beta Was this translation helpful? Give feedback.
-
|
@X-Guardian oh wow, it's not just me on terrible Bitbucket! Thanks for that fix! |
Beta Was this translation helpful? Give feedback.
-
|
Hehe, no it affected GitLab too. |
Beta Was this translation helpful? Give feedback.
-
|
@ianchesal you can use the dev image to test this out and report back docker pull ghcr.io/runatlantis/atlantis:dev |
Beta Was this translation helpful? Give feedback.
-
|
@jamengual absolutely. Will get that deployed today. |
Beta Was this translation helpful? Give feedback.
-
|
Got |
Beta Was this translation helpful? Give feedback.
-
|
Tests are successful! This resolved the issued for us. Thank you! |
Beta Was this translation helpful? Give feedback.
-
|
Awesome, we should be releasing it at the end of this week.
Thanks.
…On Wed, Sep 27, 2023 at 2:45 PM Ian Chesal ***@***.***> wrote:
Tests are successful! This resolved the issued for us. Thank you!
—
Reply to this email directly, view it on GitHub
<#3793 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQ3ERC3YGH3BFUA5RU53RDX4SM7VANCNFSM6AAAAAA5IQCKZE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Beta Was this translation helpful? Give feedback.
Hi @ianchesal, It is likely that this is resolved by #3747.