Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bitbucket Approvals should not count the pull request creator #201

Closed
lkysow opened this issue Jul 27, 2018 · 0 comments
Closed

Bitbucket Approvals should not count the pull request creator #201

lkysow opened this issue Jul 27, 2018 · 0 comments
Labels
provider/bitbucket

Comments

@lkysow
Copy link
Member

lkysow commented Jul 27, 2018 •
edited
Loading

On bitbucket cloud (not server) you can approve your own pull requests. This defeats the purpose of the require-approval flag. Atlantis should ignore approvals by the same person that created the pull request.
@lkysow lkysow mentioned this issue Jul 27, 2018
Closed
lkysow added a commit that referenced this issue Jul 28, 2018
@lkysow
Require approval from someone other than PR author
ff85cbe 
In Bitbucket cloud, the pull request author can approve their own pull
request. Ignore this approval.

Fixes #201
@lkysow lkysow mentioned this issue Jul 28, 2018
Merged
jamengual pushed a commit that referenced this issue Nov 23, 2022
@samrabelachew
Post implementation for gateway (#201)
70ffa5f 
* post implementation for gateway

* comments

* comments

* nit
meringu pushed a commit to meringu/atlantis that referenced this issue May 29, 2023
@lkysow
Update changelog for 0.2.0 (runatlantis#201)
55c536c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
provider/bitbucket
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lkysow @nitrocode