Drop docker hub support

[chenrui333]

👋 with the recent fixes for docker multiplatform image builds, we have also removed the docker hub support via circleci starting release 0.18.4.

Let me know if you have any questions or concerns, thanks!

[dgteixeira]

EDIT: Detailed our terraform resource when applying the atlantis helm chart for the most recent version

@chenrui333 hey!
I have a question.

Using helm chart v3.15.5, documented here, how can we change the container registry (from the apparent default being docker hub) to ghcr ?

With the following config on the helm chart:

resource "helm_release" "atlantis" {
  name             = "atlantis"
  repository       = "https://runatlantis.github.io/helm-charts"
  chart            = "atlantis"
  version          = "3.15.5"
  namespace        = "atlantis"
  wait_for_jobs    = true
  create_namespace = false
  values = [
    <<YAML

  image:
    repository: runatlantis/atlantis
    tag: v0.18.5

  hidePrevPlanComments: true

  defaultTFVersion: 1.1.7

  resources:
    limits:
      cpu: 3000m
      memory: 1Gi
    requests:
      cpu: 3000m
      memory: ${terraform.workspace == "staging" ? "256Mi" : "1Gi"}

  nodeSelector:
    cloud.google.com/gke-nodepool: ${var.atlantis_node_pool_name}

  tolerations:
  - key: "dedicated"
    value: "atlantis"
    operator: "Equal"
    effect: "NoSchedule"
  YAML
  ]
  depends_on = [
    kubectl_manifest.atlantis
  ]
}

We are getting the error:

Warning Failed 18m (x4 over 20m) kubelet Failed to pull image "runatlantis/atlantis:v0.18.5": rpc error: code = NotFound desc = failed to pull and unpack ima "docker.io/runatlantis/atlantis:v0.18.5": failed to resolve reference "docker.io/runatlantis/atlantis:v0.18.5": docker.io/runatlantis/atlantis:v0.18.5: not found

Since this is no longer supported, shouldn't the default endpoint also be changed to ghcr?

Thanks!

[dgteixeira]

EDIT: Created the issue in atlantis for default repo helm chart change.
@chenrui333, we fixed it by adding the ghcr.io prefix to the repository.

As follows:

  image:
    repository: ghcr.io/runatlantis/atlantis
    tag: v0.18.5

This works like a charm!

However, as stated in the previous comment, if docker.io is not supported, shouldn't be as the default repository in the helm chart. I opened the issue: #2110

[chenrui333]

Thanks for reporting, it let me update the default one.

[marceloboeira]

@chenrui333 I've updated a few broken references in the docs

[chenrui333]

I think we have waited long enough to unpin/close the issue.

[chenrui333]

Feel free to submit a new one.