if with identical then and else branches

[chavacava]

In the following code, both control branches do the same (i.e. owner = strings.Split(uri.Path, "/")[1])

atlantis/server/events/event_parser.go

Lines 926 to 930 in 2cd8bd9

	} else if strings.Contains(uri.Host, "dev.azure.com") {
	owner = strings.Split(uri.Path, "/")[1]
	} else {
	owner = strings.Split(uri.Path, "/")[1] // to support owner for self hosted
	}

Found by revive (rule identical-branches)

[jamengual]

yes but one will match a hostname and the other will not.

how do you propose to make it better?

[chavacava]

yes but one will match a hostname and the other will not.

As is written, the value of owner does not depend on the condition (strings.Contains(uri.Host, "dev.azure.com"))

how do you propose to make it better?

In general, if both branches do the same, the full if-statement can be safely replaced with any of its branches, therefore

		if strings.Contains(uri.Host, "visualstudio.com") {
			owner = strings.Split(uri.Host, ".")[0]
		} else if strings.Contains(uri.Host, "dev.azure.com") {
			owner = strings.Split(uri.Path, "/")[1]
		} else {
			owner = strings.Split(uri.Path, "/")[1] // to support owner for self hosted
		}

can be rewritten as

		if strings.Contains(uri.Host, "visualstudio.com") {
			owner = strings.Split(uri.Host, ".")[0]
		} else {
			owner = strings.Split(uri.Path, "/")[1]
		} 

Warn: accessing the second element of the result of a strings.Split (as in strings.Split(uri.Path, "/")[1]) can lead to a runtime error if the result of the split is a slice shorter than 2

[jamengual]

I C what you mean, yes , that could be improved, are you willing to send a PR over?

[chavacava]

Yes, sure, you can assign the issue to me

[jamengual]

I can't assign to you, it does not let me because you are not in the maintainers list