Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hot reloading of TLS certificates #2658

Closed
1 task done
camillsir opened this issue Nov 10, 2022 · 0 comments · Fixed by #2656
Closed
1 task done

Support hot reloading of TLS certificates #2658

camillsir opened this issue Nov 10, 2022 · 0 comments · Fixed by #2656
Labels
feature New functionality/enhancement

Comments

@camillsir
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Describe the user story

I'm currently using atlantis in a kubernetes cluster. I'm using a product called cert-manager to generate Let's Encrypt certificates. These certificates are short lived and cert manager will handle generating a new certificate and updating the certificate file. Atlantis currently only reads the TLS certificate on start.

Describe the solution you'd like

To accomplish TLS certificate rotation without restarting the application, atlantis will need to monitor the certificate path and reload the TLS certificate when the file has been modified.

Describe the drawbacks of your solution

The solution assumes that the modification (mtime) of the file changes when the certificate is updated. This works in my case, but might not work for others.

Describe alternatives you've considered

@camillsir camillsir added the feature New functionality/enhancement label Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant