Adding reloading of TLS certificates #2656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@camillsir please fix tests |
nitrocode
reviewed
Nov 10, 2022
nitrocode
reviewed
Nov 10, 2022
nitrocode
reviewed
Nov 10, 2022
Co-authored-by: nitrocode <[email protected]>
nitrocode
reviewed
Nov 10, 2022
nitrocode
approved these changes
Nov 13, 2022
|
cc: @lkysow @chenrui333 @jamengual please review to get a second set of eyes |
|
Thank you @camillsir ! |
krrrr38
pushed a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
* Adding reloading of TLS certificates * Update server/server.go Co-authored-by: nitrocode <[email protected]> * Adding test and test data * Set minimum tls version * Adding read header timeout Co-authored-by: nitrocode <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding reloading of TLS certificates without restarting the application. Tested both http and https with this change. I didn't see a way to pass in a logger so I omitted all logging steps.
This is needed as I have a use case that uses cert-manager to generate Let's Encrypt TLS certificates. These certificates have a short lifetime and need to be rotated while the application is running.
Closes #2658