Comment back on pull request if lock is discarded

[atlantisbot]

Issue by @lkysow
Thursday Jun 29, 2017 at 02:29 GMT
Migrated from hootsuite/atlantis#53
Why was it migrated?

---

None

[atlantisbot]

Comment by @anubhavmishra
Wednesday Aug 02, 2017 at 14:48 GMT

---

This is fixed here: hootsuite/atlantis#43

[atlantisbot]

Comment by @lkysow
Wednesday Aug 02, 2017 at 15:36 GMT

---

This is actually a bit different. When a user unlocks an environment from the UI we don't comment back on the pull request saying that the lock was discarded.

[mo-hit]

@lkysow I think I'm gonna take a crack at this. I see a couple ways of approaching it:

• just do it directly in server.. we gotta write templates so this would add clutter
• add a lock handler in the events controller.. but then the events controller will be additionally taking GET and DELETE non-vcs related events
• add a separate lock controller for doing this... but then its calling a bunch of stuff in the events module for vcs and locking

what do you think?