Comment back on pull request when it's closed/merged #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkysow
commented
Jun 23, 2017
locking/locking.go
Outdated
| List() ([]models.ProjectLock, error) | ||
| UnlockByPull(repoFullName string, pullNum int) error | ||
| UnlockByPull(repoFullName string, pullNum int) ([]models.ProjectLock, error) |
lkysow
commented
Jun 23, 2017
plan/backend.go
Outdated
| @@ -7,6 +7,8 @@ import ( | |||
| type Backend interface { | |||
| SavePlan(path string, project models.Project, env string, pullNum int) error | |||
| CopyPlans(dstRepoPath string, repoFullName string, env string, pullNum int) ([]Plan, error) | |||
| DeletePlan(project models.Project, env string, pullNum int) error | |||
| DeletePlansByPull(repoFullName string, pullNum int) error | |||
There was a problem hiding this comment.
new functions here for cleaning up plans. I still need to delete the plans on apply though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge #42 first.
DeletePlansByPullandDeletePlanmethods to clean up plans on apply/pull closed/errorsComment for a single env:
Comment for multiple envs:
Fixes #31
Changes
UnlockandUnlockByPullnow return what was unlockedpull_closed_executorthat handles dealing with the closed pull