-var atlantis_repo cannot contain '/' (0.4.9)

[jolexa]

-var atlantis_repo=runatlantis/atlantis is invalid per the documentation. It cannot contain a /

Maybe it should be replaced with another character? Or just drop the organization and just use the repo name?

[lkysow]

I don't think it makes sense to change the value of atlantis_repo to match the allowed chars for session_name because I can see others wanting to make use of this variable for different reasons.

What about instead using a tf function to remove the /?

provider "aws" {
  assume_role {
    role_arn     = "arn:aws:iam::ACCOUNT_ID:role/ROLE_NAME"
    session_name = "${var.atlantis_user}-${replace(var.atlantis_repo, "/[^\\w+=,.@-]/", "-")}-${var.atlantis_pull_num}"
  }
}

[jolexa]

My initial reaction is that I do not think it is great that Atlantis fails to assume a role by default ;) I cannot get onboard with having a regex in every repo at our org, not because we don't understand it but rather it is just too ugly (subjective, I know). I would rather implement either of:

• In our org, we just wouldn't use atlantis_repo and hardcode the repo name as another variable (This defeats the point of the feature but fine for us in our usage of atlantis)
• Implement another variable in the code that does the split for us. (Possibly using SplitRepoFullName )

  atlantis/server/events/models/models.go

  Line 311 in 7e2d2d1

  func SplitRepoFullName(repoFullName string) (owner string, repo string) {

[lkysow]

That's fair. I like your second suggestion. Also set:
atlantis_repo_name=atlantis
atlantis_repo_owner=runatlantis
And use those.

[lkysow]

Fixed by #300