Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform_version is not downloaded when using custom workflow #675

Closed
maximede opened this issue Jun 12, 2019 · 4 comments
Closed

terraform_version is not downloaded when using custom workflow #675

maximede opened this issue Jun 12, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@maximede
Copy link
Contributor

Following #639

It looks like when you specify a specific terraform version in terraform_version and use a custom workflow, the requested terraform binary will not be downloaded/available for the custom workflow
@lkysow lkysow added the bug Something isn't working label Jun 13, 2019
@lkysow
Copy link
Member

lkysow commented Jun 13, 2019

Yes, if you don't use any built-in steps, ex - init, then it won't download the version for you. It's a bug.

@lkysow lkysow mentioned this issue Jul 25, 2019
Closed
@maximede
Copy link
Contributor Author

@lkysow I might have a bit of time to work on this issue. I'm not completely sure how I should fix that.
Should I create a new built-in step that'd would just download the requested terraform version or should it be something smarter than that in the RUN step ?

@lkysow
Copy link
Member

lkysow commented Jul 29, 2019

  • I would make a public method on TerraformClient like EnsureVersion(log *logging.SimpleLogger, v *version.Version)
  • in its implementation I would call the internal ensureVersion method
  • Then in the RunStepRunner I would pass in TerraformClient and then call the method

@maximede
Copy link
Contributor Author

That makes sense.
I'll submit a PR soon-ish

maximede added a commit to maximede/atlantis that referenced this issue Jul 29, 2019
@maximede
Ensure is downloaded when using non built-in step. Fixes runatlantis#675
3938ff1
maximede added a commit to maximede/atlantis that referenced this issue Jul 29, 2019
@maximede
Ensure terraform_version is downloaded when using non built-in step. F…
f311102 
…ixes runatlantis#675
maximede added a commit to maximede/atlantis that referenced this issue Jul 29, 2019
@maximede
Ensure terraform_version is downloaded when using non built-in step. F…
df7af26 
…ixes runatlantis#675
@malnick malnick closed this as completed in d6f2579 Aug 1, 2019
malnick added a commit that referenced this issue Aug 1, 2019
@malnick
Merge pull request #722 from maximede/issue-675
5f9412b 
Ensure terraform_version is downloaded when using non built-in step. Fixes #675
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lkysow @maximede