Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make repo whitelist case insensitive. #100

Merged
merged 1 commit into from
Mar 30, 2018
Merged

Make repo whitelist case insensitive. #100

merged 1 commit into from
Mar 30, 2018

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Mar 30, 2018

This is okay to do because it's a better user experience and because
GitLab and GitHub project names are case insensitive as well.

Fixes #95

This is okay to do because it's a better user experience and because
GitLab and GitHub project names are case insensitive as well.
@codecov
Copy link

codecov bot commented Mar 30, 2018

Codecov Report

Merging #100 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
+ Coverage   63.78%   63.82%   +0.03%     
==========================================
  Files          40       40              
  Lines        1955     1957       +2     
==========================================
+ Hits         1247     1249       +2     
  Misses        644      644              
  Partials       64       64
Impacted Files Coverage Δ
server/events/repo_whitelist.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f016d64...3f5ad53. Read the comment docs.

@lkysow lkysow merged commit 6c86d13 into master Mar 30, 2018
@lkysow lkysow deleted the whitelist-case branch March 30, 2018 20:36
jamengual pushed a commit that referenced this pull request Nov 23, 2022
Added missing pieces for local development in the docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant