Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release locks when closing draft PRs #1038

Merged
merged 1 commit into from
May 19, 2020

Conversation

andrewring
Copy link
Contributor

If plan is run manually in a draft PR, the PR may hold locks. If the draft PR is then closed, without first marking it Ready For Review, the locks are left in place. To resolve this, we can process closing draft PRs in the same way as non-draft PRs.

Also collapses draft event parsing test into normal event parsing. Previous test did not actually test different event types.

If plan is run manually in a draft PR, the PR may hold locks. If
the draft PR is then closed, without first marking it Ready For
Review, the locks are left in place. To resolve this, we can
process closing draft PRs in the same way as non-draft PRs.
@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #1038 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1038      +/-   ##
==========================================
+ Coverage   71.96%   71.98%   +0.01%     
==========================================
  Files          65       65              
  Lines        5429     5432       +3     
==========================================
+ Hits         3907     3910       +3     
  Misses       1215     1215              
  Partials      307      307              
Impacted Files Coverage Δ
server/events/event_parser.go 86.19% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39c5ad8...3c87af9. Read the comment docs.

Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lkysow lkysow merged commit 64135af into runatlantis:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants