Support graceful shutdown #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- trigger on SIGTERM/INT rather than HTTP POST - remove atlantis drain command - refactor into generic status controller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support gracefully stopping Atlantis. When Atlantis receives a SIGTERM or SIGINT it will not shut down immediately but instead wait for in-progress operations to complete. New operations will be refused and Atlantis will comment back that "Atlantis is shutting down...". Once all in-progress operations are complete, Atlantis will exit.
Takes @benoit74's amazing work from #953 and refactors to use signals and remove
atlantis draincommand.Fixes #320