Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLab's Merge Requests are using ! not # #1059

Merged
merged 1 commit into from
May 28, 2020

Conversation

EppO
Copy link
Contributor

@EppO EppO commented May 28, 2020

fixes #948

Thanks to the ground work from #983, we can now configure GitLab's Merge Request links in the Lock Message correctly, using ! instead of # which refers to issues, not MRs.

@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #1059 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1059   +/-   ##
=======================================
  Coverage   71.47%   71.47%           
=======================================
  Files          67       67           
  Lines        5556     5556           
=======================================
  Hits         3971     3971           
  Misses       1271     1271           
  Partials      314      314           
Impacted Files Coverage Δ
server/events/vcs/gitlab_client.go 39.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc3ea77...1594fc2. Read the comment docs.

@lkysow
Copy link
Member

lkysow commented May 28, 2020

Nice, thanks for the PR and thanks to @mcdafydd for laying that groundwork!

@lkysow lkysow merged commit a1682c6 into runatlantis:master May 28, 2020
@EppO EppO deleted the fix-gitlab-mr-link branch May 28, 2020 21:23
@EppO
Copy link
Contributor Author

EppO commented May 28, 2020

Can't take the credit for that one, @mcdafydd made it so easy for me :)
Thanks for the fast feedback @lkysow, really appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gitlab lock error message refers to issue instead of MR
2 participants