Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Azure URL parameter for WriteGitCreds #1070

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

markbrennan
Copy link
Contributor

The AzureDevopsUser, AzureDevopsToken, and the AzureDevopsURL are combined
to create the .git-credentials file.
When supplying the full FQDN, https://dev.azure.com, https://
is written twice to the .git-credentials file.

The AzureDevopsUser, AzureDevopsToken, and the AzureDevopsURL are combined
to create the .git-credentials file.
When supplying the full FQDN, https://dev.azure.com, https://
is written twice to the .git-credentials file.
@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #1070 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1070   +/-   ##
=======================================
  Coverage   71.49%   71.49%           
=======================================
  Files          67       67           
  Lines        5564     5564           
=======================================
  Hits         3978     3978           
  Misses       1272     1272           
  Partials      314      314           
Impacted Files Coverage Δ
server/server.go 61.83% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f496c8...1269c8f. Read the comment docs.

Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lkysow lkysow merged commit 6e0f265 into runatlantis:master Jun 2, 2020
@jpreese
Copy link
Contributor

jpreese commented Jun 3, 2020

@markbrennan did this resolve #964 as well? It looks related.

@markbrennan
Copy link
Contributor Author

It's related, but I don't think it will resolve that issue as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants