Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Option to globally disable apply #1230

Merged
merged 4 commits into from
Oct 28, 2020
Merged

Add Option to globally disable apply #1230

merged 4 commits into from
Oct 28, 2020

Conversation

gezb
Copy link
Contributor

@gezb gezb commented Oct 19, 2020

Implement a new server flag that will disable the ability to run atlantis apply, as suggested in #1219

@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #1230 into master will increase coverage by 0.02%.
The diff coverage is 82.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1230      +/-   ##
==========================================
+ Coverage   69.95%   69.98%   +0.02%     
==========================================
  Files          71       71              
  Lines        5362     5380      +18     
==========================================
+ Hits         3751     3765      +14     
- Misses       1263     1265       +2     
- Partials      348      350       +2     
Impacted Files Coverage Δ
cmd/server.go 79.09% <ø> (ø)
server/events_controller.go 56.07% <ø> (ø)
server/user_config.go 100.00% <ø> (ø)
server/events/command_runner.go 50.87% <60.00%> (+0.16%) ⬆️
server/events/comment_parser.go 93.98% <81.81%> (-1.18%) ⬇️
server/events/markdown_renderer.go 92.20% <100.00%> (+0.10%) ⬆️
server/server.go 61.34% <100.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c789e1a...aeb6c50. Read the comment docs.

Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It looks super good. Can you also update the website flag docs?

server/events/comment_parser.go Show resolved Hide resolved
server/events/comment_parser.go Outdated Show resolved Hide resolved
server/events/comment_parser.go Outdated Show resolved Hide resolved
cmd/server.go Outdated Show resolved Hide resolved
cmd/server.go Outdated Show resolved Hide resolved
@gezb
Copy link
Contributor Author

gezb commented Oct 25, 2020

@lkysow I have addressed your comments and pushed my changes

One issue I see now is the fact that we will not be able to plan multiple PR's because of the locking. I see there is #1212 been raised would this be best as another feature/server-flag that can be used alongside --disable-apply?

I would not look to remove locking but if the flag is enabled unlock the repo automatically once the plan has completed allowing other plans to be run?

Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting close, thanks for the attention to detail.

cmd/server_test.go Outdated Show resolved Hide resolved
runatlantis.io/docs/server-configuration.md Outdated Show resolved Hide resolved
server/events/comment_parser.go Outdated Show resolved Hide resolved
server/events/comment_parser.go Outdated Show resolved Hide resolved
server/events/comment_parser.go Outdated Show resolved Hide resolved
server/events/comment_parser.go Outdated Show resolved Hide resolved
server/events_controller.go Outdated Show resolved Hide resolved
server/events/markdown_renderer.go Outdated Show resolved Hide resolved
server/events/comment_parser_test.go Outdated Show resolved Hide resolved
server/events/comment_parser_test.go Show resolved Hide resolved
@gezb
Copy link
Contributor Author

gezb commented Oct 27, 2020

I have addressed the last round of comments and re-based, I have left one review comment unresolved as I am not sure how I proceed with that one

@lkysow lkysow merged commit d2610a7 into runatlantis:master Oct 28, 2020
ilyaluk pushed a commit to joomcode/atlantis that referenced this pull request Dec 15, 2020
* Add Option to globally disable apply

Co-authored-by: Gerald Barker <[email protected]>
msarvar referenced this pull request in lyft/atlantis Mar 2, 2021
* Add Option to globally disable apply

Co-authored-by: Gerald Barker <[email protected]>
@gezb gezb deleted the feature/disable_apply branch June 25, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants