Pass atlantis/apply when there are no plans #1323
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a pull request has no Terraform changes at all, Atlantis passes the atlantis/plan check, but it doesn't pass the atlantis/apply check. This means that while it's possible to enable the atlantis/plan check as required in the branch protection settings, it's not possible to do the same for atlantis/apply (otherwise for PRs with no Terraform changes you have to run a no-op
atlantis apply
). The fix is simple: pass both checks in the case of no Terraform changes.