Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass atlantis/apply when there are no plans #1323

Merged

Conversation

raxod502-plaid
Copy link
Contributor

When a pull request has no Terraform changes at all, Atlantis passes the atlantis/plan check, but it doesn't pass the atlantis/apply check. This means that while it's possible to enable the atlantis/plan check as required in the branch protection settings, it's not possible to do the same for atlantis/apply (otherwise for PRs with no Terraform changes you have to run a no-op atlantis apply). The fix is simple: pass both checks in the case of no Terraform changes.

@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #1323 (464c105) into master (b6e8403) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1323      +/-   ##
==========================================
- Coverage   70.06%   70.03%   -0.03%     
==========================================
  Files          71       71              
  Lines        5391     5393       +2     
==========================================
  Hits         3777     3777              
- Misses       1264     1266       +2     
  Partials      350      350              
Impacted Files Coverage Δ
server/events/command_runner.go 50.52% <0.00%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6e8403...464c105. Read the comment docs.

Copy link
Contributor

@acastle acastle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎄

@mathcantin
Copy link
Contributor

That will make easier to add a check in github.

@nishkrishnan nishkrishnan merged commit 63a6e64 into runatlantis:master Jan 28, 2021
@raxod502-plaid raxod502-plaid deleted the pass-atlantis-apply-also branch January 28, 2021 19:36
@GaloGlober
Copy link

Hi, awesome change/improvement! Surely it will come out in the next release right? If so, do you guys have an estimate when this would be?

@GaloGlober
Copy link

Hi, awesome change/improvement! Surely it will come out in the next release right? If so, do you guys have an estimate when this would be?

OK, just saw it has been released already, you guys are fast! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants