Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump terraform version to latest 0.15.1 #1512

Merged
merged 9 commits into from
Apr 26, 2021
Merged

chore: bump terraform version to latest 0.15.1 #1512

merged 9 commits into from
Apr 26, 2021

Conversation

bryantbiggs
Copy link
Contributor

@bryantbiggs bryantbiggs commented Apr 16, 2021

  • chore: bump Terraform version to latest 0.15.0 0.15.1

@bryantbiggs bryantbiggs requested a review from a team as a code owner April 16, 2021 00:58
@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #1512 (8325ca3) into master (25103d7) will decrease coverage by 0.12%.
The diff coverage is n/a.

❗ Current head 8325ca3 differs from pull request most recent head 6a07ddc. Consider uploading reports for the commit 6a07ddc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1512      +/-   ##
==========================================
- Coverage   70.21%   70.08%   -0.13%     
==========================================
  Files          94       94              
  Lines        6530     6485      -45     
==========================================
- Hits         4585     4545      -40     
+ Misses       1555     1554       -1     
+ Partials      390      386       -4     
Impacted Files Coverage Δ
server/events/plan_command_runner.go 40.94% <0.00%> (-6.85%) ⬇️
server/events/unlock_command_runner.go 85.71% <0.00%> (-2.53%) ⬇️
server/events/approve_policies_command_runner.go 68.88% <0.00%> (-1.49%) ⬇️
server/events/delete_lock_command.go 75.00% <0.00%> (-0.87%) ⬇️
server/events/apply_command_runner.go 71.60% <0.00%> (-0.62%) ⬇️
server/server.go 65.14% <0.00%> (-0.55%) ⬇️
cmd/server.go 79.09% <0.00%> (ø)
server/user_config.go 100.00% <0.00%> (ø)
server/events/policy_check_command_runner.go 21.87% <0.00%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ba9707...6a07ddc. Read the comment docs.

Dockerfile Outdated
@@ -3,7 +3,7 @@ FROM runatlantis/atlantis-base:v3.5
LABEL authors="Anubhav Mishra, Luke Kysow"

# install terraform binaries
ENV DEFAULT_TERRAFORM_VERSION=0.14.10
ENV DEFAULT_TERRAFORM_VERSION=0.15.0

# In the official Atlantis image we only have the latest of each Terraform version.
RUN AVAILABLE_TERRAFORM_VERSIONS="0.8.8 0.9.11 0.10.8 0.11.14 0.12.30 0.13.6 ${DEFAULT_TERRAFORM_VERSION}" && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't 0.14.10 be added here for folks still on the 0.14 branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah good catch, just pushed the update for this! thanks!

@nishkrishnan
Copy link
Contributor

Looks good but like @pauloconnor said, let's add the latest version of 0.14 in the available versions.

@nishkrishnan nishkrishnan added the waiting-on-response Waiting for a response from the user label Apr 22, 2021
@bryantbiggs
Copy link
Contributor Author

@nishkrishnan does the default conftest version need to be bumped from v0.21.0 -> v0.22.0+?

@nishkrishnan
Copy link
Contributor

@nishkrishnan does the default conftest version need to be bumped from v0.21.0 -> v0.22.0+?

yeah this PR will fix it #1516 sorry about the inconvenience.

@bryantbiggs
Copy link
Contributor Author

ah ok - no worries, thanks!

@lkysow
Copy link
Member

lkysow commented Apr 23, 2021

FYI #1516 was just merged. You'll need to ensure you rebase off of the latest master branch since we've made some changes to the CI.

@bryantbiggs
Copy link
Contributor Author

not sure if I'm missing something or if a maintainer has to approve the CI process somewhere
image

@lkysow
Copy link
Member

lkysow commented Apr 24, 2021

#1530 should fix this. Sorry, we're rejigging our builds after the codecov issue.

@lkysow
Copy link
Member

lkysow commented Apr 24, 2021

Okay please rebase and see if that fixed it

@bryantbiggs
Copy link
Contributor Author

woot 🎉

@bryantbiggs bryantbiggs changed the title chore: bump terraform version to latest 0.15.0 chore: bump terraform version to latest 0.15.1 Apr 26, 2021
@nishkrishnan nishkrishnan merged commit 04824c2 into runatlantis:master Apr 26, 2021
@bryantbiggs bryantbiggs deleted the chore/terraform-version-bump branch April 26, 2021 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-on-response Waiting for a response from the user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants