[WIP] Atlantis 0.4 #152
Merged
[WIP] Atlantis 0.4 #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes things cleaner because there will only ever be one plan generated in the comment flow. It's okay to make this change because typing the plan command a couple times isn't too bad AND we're going to be implementing autoplanning which should handle most of the times you needed to type plan from before.
Even though we're switching to the right workspace this is a nice safeguard to have. I don't think it incurs additional time.
- Fix lockURL issues by adding new Router object. - Use new ProjectLocker and delete PreProjectExecutor.
lkysow
force-pushed
the
atlantis-yaml-june
branch
from
8b245d0
to
e4bf6d7
Compare
lkysow
force-pushed
the
atlantis-yaml-june
branch
from
e4bf6d7
to
13a70c7
Compare
|
Hi, It seems to be the expected behavior in terraform : https://github.com/hashicorp/terraform/blob/master/command/workspace_select.go#L46 I think the addition of |
|
@bewie okay great good to know, I'll remove that since it's not needed because I manually switch workspaces. Thanks! |
|
@bewie I pushed new commits to this branch that remove that variable. |
|
@lkysow , I tested on my side it's works! 👍 |
- delete working dir when lock deleted - check if dir still exists when looking at modified - check if atlantis.yaml is allowed before parsing
This was referenced Jul 4, 2018
jamengual
pushed a commit
that referenced
this pull request
Nov 23, 2022
meringu
pushed a commit
to meringu/atlantis
that referenced
this pull request
May 29, 2023
Ensure planfile is last arg to apply. Fixes runatlantis#151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo
Features
--require-approvalflag--enable-repoconfigflag that enablesatlantis.yamlfiles since they're a security vulnerabilityCode Quality