Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an extra flag to disable automerge with comment apply #1533

Merged

Conversation

spirosoik
Copy link
Contributor

atlantis apply --auto-merge-disabled

Issue: #1245

@spirosoik spirosoik requested a review from a team as a code owner April 26, 2021 06:33
@spirosoik spirosoik force-pushed the feat/auto-merge-disabled-flag branch from 0cf2221 to 152d35a Compare April 26, 2021 08:10
```
atlantis apply --auto-merge-disabled
```

Issue: runatlantis#1245
@spirosoik spirosoik force-pushed the feat/auto-merge-disabled-flag branch from 152d35a to a97cc87 Compare April 26, 2021 08:17
Copy link
Contributor

@acastle acastle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@akostrikov
Copy link

chenrui333 approved these changes 29 days ago
Are we going to merge?

@nishkrishnan nishkrishnan merged commit e48f803 into runatlantis:master Jun 22, 2021
dupuy26 added a commit to dupuy26/atlantis that referenced this pull request Oct 1, 2021
This flag was added in runatlantis#1533 but was not documented.
chenrui333 pushed a commit that referenced this pull request Oct 1, 2021
This flag was added in #1533 but was not documented.
@jeff-clearcover
Copy link

jeff-clearcover commented Nov 15, 2022

I know this is old but this flag reads confusing, can we potentially change this flag to --disable-auto-merge or support this as well?

@nitrocode
Copy link
Member

@jeff-clearcover please create a new issue and or propose a pr

krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants