-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix support for terraform workspaces #1578
Conversation
This reverts commit 2c4e0c3
any chance to get this merged in soon? #1363 has broken almost all our workflows. |
Bumping this one more time. |
@monitrue could you fix the conflicts? |
@jamengual @monitrue I am 100% ready to resolve the conflicts and fix this up... is that cool? This is a blocker for us as well I think. Unsure how workspaces are supported at all if this prevents workspaces from being used in atlantis... |
go for it. |
@bschaeffer Absolutely mate, go for it! I lost hope that this fix will ever be merged. |
Fixes runatlantis#1517 and basically is a rebased version of runatlantis#1578.
Unsure how to rebase someone else's branch, so just did it in a new PR #2006 |
Fixed in #2006 |
Fixes runatlantis#1517 and basically is a rebased version of runatlantis#1578.
PR #1363 hardcoded a 3rd-party configuration variable (Terraform's TF_WORKSPACE), breaking terraform workspaces support in Atlantis.
This PR reverts the change made by #1363 to restore support for terraform workspaces. Users wishing to set TF_WORKSPACE to any value including the current workspace name, can easily do so with a custom workflow, or by externally setting the TF_WORKSPACE environment variable system-wide or session-wide.
Please see #1517 for bug report.