Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plan summary when the changes outside of terraform are detected (#1593) #1594

Merged
merged 2 commits into from
Jun 24, 2021

Conversation

chroju
Copy link
Contributor

@chroju chroju commented May 21, 2021

Fix #1593 .

The plan summary is now displayed even when changes outside of terraform are detected. Also, the Note: displayed at changes detected is included in the plan summary.

Here's a sample.

スクリーンショット 2021-05-21 20 25 04

@chroju chroju requested a review from a team as a code owner May 21, 2021 11:25
@chroju chroju changed the title Fix plan summary when changes outside of terraform is detected (#1593) Fix plan summary when the changes outside of terraform are detected (#1593) May 24, 2021
Copy link
Contributor

@nishkrishnan nishkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can merge once the tests pass.

@nishkrishnan nishkrishnan added the waiting-on-response Waiting for a response from the user label Jun 22, 2021
@chroju
Copy link
Contributor Author

chroju commented Jun 24, 2021

@nishkrishnan
Thanks for your review. I have fixed the tests by merging the master branch.
(The test failure was caused by the commit other than mine, and was fixed on the master branch)

@nishkrishnan nishkrishnan removed the waiting-on-response Waiting for a response from the user label Jun 24, 2021
@nishkrishnan nishkrishnan merged commit e0f5b83 into runatlantis:master Jun 24, 2021
@chroju chroju deleted the fix/tf0_15_4_outputs branch June 30, 2021 02:44
msarvar referenced this pull request in lyft/atlantis Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plan summary does not appear when changes outside of Terraform are detected
2 participants