allow user to pass gh-app-key directly instead of filename #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
feedback welcome 🙏 |
unRob
reviewed
Jul 19, 2021
There was a problem hiding this comment.
This is really cool! Would you mind updating the docs as well?
Here's a couple of places I can think of that would need an update
- https://github.com/runatlantis/atlantis/blob/master/runatlantis.io/docs/server-configuration.md#--gh-app-key-file
- https://github.com/runatlantis/atlantis/blob/master/runatlantis.io/docs/access-credentials.md#github-app)
Aside from that, looks good to me
|
Thanks ! Doc is updated now. Apart from the files you mentioned I haven't found any other files where an update was necessary. |
unRob
reviewed
Jul 23, 2021
Co-authored-by: Roberto Hidalgo <[email protected]>
nishkrishnan
approved these changes
Aug 3, 2021
|
is there pls an expected timeline for releasing this? |
msarvar
referenced
this pull request
in lyft/atlantis
Sep 27, 2021
* allow user to pass gh-app-key directly instead of filename * start fixing tests * fix make test * update website with info about new flag * Apply suggestions from code review Co-authored-by: Roberto Hidalgo <[email protected]> Co-authored-by: Roberto Hidalgo <[email protected]>
krrrr38
pushed a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
…is#1706) * allow user to pass gh-app-key directly instead of filename * start fixing tests * fix make test * update website with info about new flag * Apply suggestions from code review Co-authored-by: Roberto Hidalgo <[email protected]> Co-authored-by: Roberto Hidalgo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1636