Add support for deleting a branch on merge in BitBucket Server #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 2, 2021 02:30
…ranch' into feature/bitbucketserver-delete-branch # Conflicts: # server/events/vcs/bitbucketserver/client.go
|
Can we get a review on this PR? |
|
Thanks for your contribution! |
|
I just looked through all the server/events/vcs clients and none of them actual test for DeleteSourceBranchOnMerge. If they have it then the value is always set to false. So how would I write a portable test for this. Do you all have a specific version BitBucket server in place? |
|
Nvm, I think I see a path forward on how to write a test. |
jamengual
approved these changes
Sep 27, 2021
krrrr38
pushed a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
…lantis#1792) * Add support for deleting a branch on merge in BitBucket Server * Add support for deleting a branch on merge in BitBucket Server * Making linter happy although the code would fall through and return err anyway. * Add client_test for deleting source branch * Added err check Co-authored-by: Wendell Beckwith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the support for the delete_source_branch_on_merge attribute of a atlantis.yaml file for the BitBucket Server.