feat: filter out atlantis/apply from mergeability clause #1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nishkrishnan
changed the title
|
Should fix: #523 |
chenrui333
reviewed
Oct 19, 2021
| @@ -75,12 +74,15 @@ func (d *DefaultCommitStatusUpdater) UpdateCombinedCount(repo models.Repo, pull | |||
| return d.Client.UpdateStatus(repo, pull, status, src, fmt.Sprintf("%d/%d projects %s successfully.", numSuccess, numTotal, cmdVerb), "") | |||
| } | |||
|
|
|||
| func (d *DefaultCommitStatusUpdater) UpdateProject(ctx models.ProjectCommandContext, cmdName models.CommandName, status models.CommitStatus, url string) error { | |||
| func (d *DefaultCommitStatusUpdater) UpdateProject(ctx models.ProjectCommandContext, command models.CommandName, status models.CommitStatus, url string) error { | |||
There was a problem hiding this comment.
nitpick, cmdName might be better than command
chenrui333
approved these changes
Oct 19, 2021
chenrui333
changed the title
nishkrishnan
referenced
this pull request
in lyft/atlantis
Nov 18, 2021
Filter out atlantis apply status during mergeability check.
nishkrishnan
referenced
this pull request
in lyft/atlantis
Nov 18, 2021
Filter out atlantis apply status during mergeability check.
nishkrishnan
added a commit
that referenced
this pull request
Jan 1, 2022
krrrr38
pushed a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
…#1856) Filter out atlantis apply status during mergeability check.
krrrr38
pushed a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
runatlantis#1968) * Revert "feat: filter out atlantis/apply from mergeability clause (runatlantis#1856)" This reverts commit d01796b. * Add missing import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just cherry picked the relevant commits from the lyft/atlantis. I'm going to remove the lyft specific things that aren't relevant and parameterize the status check name based on the server flag before this is ready for review.
Basically, this adds onto the mergeability checker in github client by fetching all the commit statuses and filtering out atlantis/apply from the status (in the case that mergeability returns false).