Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Optimize vertical space in comments #2269

Closed
wants to merge 1 commit into from
Closed

feat: Optimize vertical space in comments #2269

wants to merge 1 commit into from

Conversation

gtirloni
Copy link
Contributor

  • Moved comments and commands in the same line (browser will wrap it if needed on really small screens)
  • Removed "Ran" word from templates

@gtirloni gtirloni requested a review from a team as a code owner May 19, 2022 16:04
@jamengual jamengual added waiting-on-review Waiting for a review from a maintainer templates labels May 19, 2022
@jamengual
Copy link
Contributor

@gtirloni can you pul from master to fix the tests?

thanks.

@nitrocode nitrocode added waiting-on-response Waiting for a response from the user and removed waiting-on-review Waiting for a review from a maintainer labels Nov 20, 2022
@nitrocode
Copy link
Member

Please fix conflicts and merge from main

@nitrocode
Copy link
Member

Thank you for the PR. It would help to see the before and after rendered template here to see the value-add.

Recently, custom templates have merged in PR #2647 and planned to be released as part of v0.21.0. I wonder if custom templates would be a reasonable escape hatch to avoid having to do the change in this PR as a default.

@nitrocode nitrocode marked this pull request as draft December 14, 2022 07:08
@nitrocode nitrocode added the unmaintained Looking for community to build upon label Jan 24, 2023
@nitrocode nitrocode closed this Jan 24, 2023
@nitrocode
Copy link
Member

Please reopen when ready to submit for review again. Thank you for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
templates unmaintained Looking for community to build upon waiting-on-response Waiting for a response from the user
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gtirloni @jamengual @nitrocode