Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitbucket Server: Send password as Bearer instead of Basic Auth #2461

Merged
merged 3 commits into from
Oct 31, 2022

Conversation

Dev25
Copy link
Contributor

@Dev25 Dev25 commented Aug 19, 2022

The atlantis docs for using with Bitbucket Server tells users to create Personal Access Tokens for authenticating with Bitbucket Server.

As per bitbucket Using HTTP access tokens, you can send the token as Basic Auth or Bearer with the latter being recommended. Using bearer also has the benefit of working with restricted environments where basic auth may be disabled on bitbucket.

@Dev25 Dev25 requested a review from a team as a code owner August 19, 2022 10:18
@jamengual jamengual added waiting-on-review Waiting for a review from a maintainer feature New functionality/enhancement labels Aug 19, 2022
@jamengual
Copy link
Contributor

@Dev25 can you updates the docs too?

@Dev25
Copy link
Contributor Author

Dev25 commented Oct 19, 2022

@jamengual I can do but what docs were you hoping for here? The current docs linked above ask users to create a personal access token which is not changing at all. I can add a note to indicate that the token will be sent as a Bearer token to Bitbucket?

@jamengual
Copy link
Contributor

@jamengual I can do but what docs were you hoping for here? The current docs linked above ask users to create a personal access token which is not changing at all. I can add a note to indicate that the token will be sent as a Bearer token to Bitbucket?

yes, a not should be enough.

@Dev25
Copy link
Contributor Author

Dev25 commented Oct 31, 2022

Docs updated @jamengual

@jamengual
Copy link
Contributor

Thanks @Dev25 for the contribution

@jamengual jamengual merged commit c03ef1d into runatlantis:master Oct 31, 2022
@Dev25 Dev25 deleted the bitbucket-bearer-auth branch October 31, 2022 22:05
krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
…tlantis#2461)

* Bitbucket Server: Send password as Bearer instead of Basic Auth

Signed-off-by: Devan Patel <[email protected]>

* docs: Add Bearer note for Bitbucket Server auth

Signed-off-by: Dev <[email protected]>

Signed-off-by: Devan Patel <[email protected]>
Signed-off-by: Dev <[email protected]>
@nitrocode nitrocode added this to the 0.21.0 milestone Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement waiting-on-review Waiting for a review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants