Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade Git clone locking mechanism to go1.19 #2521

Merged
merged 3 commits into from
Nov 19, 2022
Merged

upgrade Git clone locking mechanism to go1.19 #2521

merged 3 commits into from
Nov 19, 2022

Conversation

ribejara-te
Copy link
Contributor

No description provided.

@ribejara-te
Copy link
Contributor Author

Tests fail because:

server/events/working_dir.go:209:20: mutex.TryLock undefined (type *sync.Mutex has no field or method TryLock)

This is because it ain't using go1.19 which includes *sync.Mutex.TryLock().

Feel free to upgrade this PR to 1.19, maintainer edits are enabled.

@jamengual
Copy link
Contributor

Tests fail because:

server/events/working_dir.go:209:20: mutex.TryLock undefined (type *sync.Mutex has no field or method TryLock)

This is because it ain't using go1.19 which includes *sync.Mutex.TryLock().

Feel free to upgrade this PR to 1.19, maintainer edits are enabled.

thanks @ribejara-te we will work on this soon.

@jamengual jamengual added help wanted Good feature for contributors dependencies PRs that update a dependency file labels Sep 14, 2022
@nitrocode
Copy link
Member

@ribejara-te please fix conflicts and rebase/merge from the default branch. Atlantis is now using go1.19.

@ribejara-te
Copy link
Contributor Author

$ docker run -it ghcr.io/runatlantis/testing-env:2021.08.31 go version
go version go1.17 linux/amd64

How do we get this fixed? @nitrocode

@nitrocode
Copy link
Member

Ah that is located here

# TODO: fix tests to use ghcr.io/runatlantis/testing-env:2022.11.13
- image: ghcr.io/runatlantis/testing-env:2021.08.31

And the latest testing-env is 2022-11-13

I tried bumping this over the weekend and saw some test failures so if you do require using the latest testing environment then you will need to troubleshoot those and fix unfortunately.

@nitrocode
Copy link
Member

@ribejara-te I updated to our latest testing-env image today and merged your branch with the default branch.

@nitrocode
Copy link
Member

cc: @jamengual @chenrui333 please review in case I'm missing something. Is this change safe? Or will it break existing functionality?

Copy link
Member

@nitrocode nitrocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but let's get a second opinion too before merging

@nitrocode nitrocode added waiting-on-review Waiting for a review from a maintainer and removed help wanted Good feature for contributors labels Nov 19, 2022
@nitrocode nitrocode merged commit 020eeba into runatlantis:main Nov 19, 2022
@nitrocode
Copy link
Member

Thank you @ribejara-te !

krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
@nitrocode nitrocode added this to the 0.21.0 milestone Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies PRs that update a dependency file waiting-on-review Waiting for a review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants