Adding Redis DB option #2527
Merged
Adding Redis DB option #2527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows selecting something other than the default database of 0.
|
Looks good to me from my end, we’ll see if the maintainers pull this in for the next release or not. |
jamengual
approved these changes
Sep 21, 2022
krrrr38
pushed a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
* Adding Redis DB option This allows selecting something other than the default database of 0. * Add missing db argument to fix failing tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes the remaining Redis connection option,
DB, which was hard-coded to0in the initial Redis Locking DB work.This allows selecting something other than the default database of
0. Atlantis may now use a different numerical database if needed, while still defaulting to0. Common use case is multiple applications using the same redis server and using database as a mechanism for name spacing different applications. This could also allow multiple atlantis instances to share a single redis instance and separate locks by database. cc @SudoSpartanDan