Add custom templates support (#2481) #2541
Conversation
|
Error is: I don't get the point of that, why does Go have init functions then? |
jamengual
added
feature
|
@jamengual what are the next steps here? |
|
Ping! |
|
we go backward in PR reviews, we try to do the oldest first but sometimes we merge quick wins like docs and others like that so sadly you need to wait for one of us to review it. this is an opensource project, no one is on payroll or contract so it is all volunteered time. Thanks. |
|
No I know, it was more about asking whether the ball was on my court or yours. No worries, I do understand. |
|
And thanks for maintaining this project. |
|
thanks for your understanding.
…On Mon, Oct 10, 2022, 1:53 a.m. ribejara-te ***@***.***> wrote:
And thanks for maintaining this project.
—
Reply to this email directly, view it on GitHub
<#2541 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQ3ERBENBO3WPRNMRUC3CLWCPKP5ANCNFSM6AAAAAAQWVZCWE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@ribejara-te can you please add docs and examples on how to use it. |
|
@ribejara-te please also fix the linting errors |
|
Sure, I will. |
| ) | ||
|
|
||
| func init() { |
There was a problem hiding this comment.
How can we rewrite this without an init function?
There was a problem hiding this comment.
I can probably encapsulate it into a nameless function.
There was a problem hiding this comment.
Thank you for all the work you have put in so far. We're really close to getting this merged in. 😁
|
Apologies on the delay, higher priority stuff seems to have taken my time these days. Will follow instructions as soon as possible. |
|
Please let us know when you're ready for another review. To resolve the branch PR check failure, please merge the latest changes from the default branch |
|
@ribejara-te we want to do a prerelease today, do you think you can fix status? |
|
Merged in #2647. |
|
Thank you again for your work! It's nice when we have so many ambitious contributors. Please feel free to propose new changes 😄 |
This closes #2481 #2602
It embeds the default templates and adds the option to pass an optional
templatesdirectory (in Atlantis' working directory) where users can override the default ones.