Update terraform-config-inspect #2599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes runatlantis#2598 This package was enough out of date that it wouldn't parse features in the language that were added in the last few releases of TF. This should get things into a state that supports the newer features.
jamengual
added
waiting-on-review
jamengual
reviewed
Oct 27, 2022
| @@ -22,7 +22,7 @@ require ( | |||
| github.com/gorilla/websocket v1.5.0 | |||
| github.com/hashicorp/go-getter v1.6.2 | |||
| github.com/hashicorp/go-version v1.6.0 | |||
| github.com/hashicorp/terraform-config-inspect v0.0.0-20200806211835-c481b8bfa41e | |||
| github.com/hashicorp/terraform-config-inspect v0.0.0-20221012204812-413b69327090 | |||
There was a problem hiding this comment.
could you update to v0.0.0-20221020162138-81db043ad408 please?
nitrocode
previously approved these changes
Oct 27, 2022
|
Looks like the test error says |
jamengual
approved these changes
Oct 27, 2022
|
sorry @tpickett66 the version I gave you does not work with the version of golang we are using, sorry but can you just use the original version you had? |
tpickett66
force-pushed
the
update-terraform-config-inspect
branch
from
764622c
to
7abdc6d
Compare
|
I've removed the second update commit from the branch. |
|
Thanks @tpickett66 for the contribution |
krrrr38
pushed a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
Fixes runatlantis#2598 This package was enough out of date that it wouldn't parse features in the language that were added in the last few releases of TF. This should get things into a state that supports the newer features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2598
This package was enough out of date that it wouldn't parse features in the language that were added in the last few releases of TF. This should get things into a state that supports the newer features.
The test suite mostly passes except for those requiring conftest. I installed the latest version using homebrew and it still wasn't found even though it is on
$PATH. I looked at the failing test and surrounding code and while the error message says>= 0.25.0the tests are actually looking for a binary named with that exact version. Adding a symlink to my 0.34.0 installation with the exact name expected allowed the tests to fail with a new error. Fixing this is outside the scope of this PR.