Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use official slack/slack-go library #2669

Merged
merged 2 commits into from
Nov 13, 2022
Merged

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Nov 11, 2022

what

  • Use official slack/slack-go library
  • Removed a couple tests

why

  • Deprecate previous nlopes/slack
  • Good security practice to use a well-maintained and official dependency
  • Couple mock tests were removed because of the inability to test them with variadic params (see issue)

references

notes

  • Needed to regenerate the mocks using pegomock which was difficult. It would be good to replace pegomock with something more up to date. It's also questionable how much value is generated from a mocked test for a function that wraps an upstream library.

@nitrocode
Copy link
Member Author

@nishkrishnan if you have time, I'd love a second look on these tests

@nitrocode nitrocode marked this pull request as ready for review November 13, 2022 02:16
@nitrocode nitrocode requested a review from a team as a code owner November 13, 2022 02:16
Copy link
Contributor

@jamengual jamengual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nitrocode nitrocode merged commit ac6a823 into runatlantis:master Nov 13, 2022
@nitrocode nitrocode deleted the slack-go branch November 13, 2022 02:32
krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
* Use slack-go

* rm'ed a couple tests due open issue in pegomock
@nitrocode nitrocode mentioned this pull request Dec 27, 2022
21 tasks
@nitrocode nitrocode added this to the 0.21.0 milestone Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use official slack/slack-go client
2 participants