Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump all dependencies #2675

Merged
merged 2 commits into from
Nov 14, 2022
Merged

Bump all dependencies #2675

merged 2 commits into from
Nov 14, 2022

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Nov 13, 2022 •
edited
Loading

what

  • Bump all dependencies

why

  • Latest version

references

notes

go get -u
# If this is unpinned, it uses v1.12.1 which isn't out yet and v1.11.1 causes issues
go get github.com/zclconf/[email protected]
# The latest version is v1.6.1 which is a large upgrade
go get github.com/spf13/[email protected]
# The latest version is v1.19.0 which is a large upgrade
go get github.com/briandowns/[email protected]
# The latest version is v0.0.0-20221020162138-81db043ad408 which isn't a large upgrade but
# the error thrown is:
# /go/pkg/mod/github.com/hashicorp/[email protected]/tfconfig/filesystem.go:93:37: undefined: any

go get github.com/hashicorp/[email protected]

# rebuild go.mod and go.sum
go mod tidy
# test build
go build .
# run local tests
make test
# This always fails for me locally
#make test-all

@nitrocode nitrocode requested a review from a team as a code owner November 13, 2022 22:50
@nitrocode nitrocode marked this pull request as draft November 13, 2022 23:11
@nitrocode nitrocode force-pushed the bump-all-dependencies branch 6 times, most recently from 1268577 to 7aa9685 Compare November 13, 2022 23:36
@nitrocode nitrocode marked this pull request as ready for review November 14, 2022 02:55
@nitrocode nitrocode merged commit ec995dd into master Nov 14, 2022
@nitrocode nitrocode deleted the bump-all-dependencies branch November 14, 2022 06:50
@chenrui333 chenrui333 added the dependencies PRs that update a dependency file label Nov 14, 2022
chenrui333
chenrui333 reviewed Nov 14, 2022
View reviewed changes
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
@nitrocode @krrrr38
Bump all dependencies (runatlantis#2675)
c20c224 
* Bump all dependencies using go get -u

* Added nolint: gosec for writing git creds
@nitrocode nitrocode added this to the 0.21.0 milestone Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 left review comments

@jamengual jamengual jamengual approved these changes

Assignees
No one assigned
Labels
dependencies PRs that update a dependency file
Projects
None yet
Milestone
v0.21.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nitrocode @chenrui333 @jamengual