-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable or disable repo_locking
per repo in repos.yaml
and atlantis.yaml
#2700
Enable or disable repo_locking
per repo in repos.yaml
and atlantis.yaml
#2700
Conversation
0c4240b
to
9d52bbc
Compare
repo_locking
per repo in repos.yaml
and atlantis.yaml
Thank you @krrrr38 for addressing the feedback. @jamengual and the other maintainers have locked the |
e1dfe10
to
795328f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure why the tests are failing but it does not seem relevant to this PR.
cc: @jamengual please review if you a some time since there have been changes. If you're good, then I'm ok with this as well |
Verbal agreement from @jamengual in slack. Merging! |
Thank you @krrrr38 for the contribution! |
@krrrr38 let us know if you're interested in becoming a maintainer. We're looking for more maintainers with high quality PRs who are interested in keeping atlantis in a well-maintained state. |
@nitrocode Sounds good to me. I'm not sure to support how much time I can spend, but I can focus on Atlantis a little bit more when I become a maintainer. I will use terraform and atlantis for a while in the future, cause this is a great product which supports continuous delivery with git-* flow. So I'm happy to contribute atlantis. |
…is.yaml` (runatlantis#2700) * disable repo locking repos.yaml and atlantis.yaml with allow override * rename disable_repo_locking into repo_locking * add both enable/disable repo_locking test Co-authored-by: nitrocode <[email protected]>
…is.yaml` (runatlantis#2700) * disable repo locking repos.yaml and atlantis.yaml with allow override * rename disable_repo_locking into repo_locking * add both enable/disable repo_locking test Co-authored-by: nitrocode <[email protected]>
What did I change?
repo_locking
setting in repo config and atlantis.yaml.repo_locking
by atlantis.yamlProjectLocker
hasNoOpLocker
andTryLock
checkrepoLocking bool
arg.repoLocking
is false, ProjectLocker doesn't get a lock usingNoOpLocker
Check
I just add some unit tests and check manually in krrrr38/atlantis-debug#1 and krrrr38/atlantis-debug#2.
In this case, I use the following repo config which contains
allowed_overrides: [repo_locking]
.And put
atlantis.yaml
which containsrepo_locking: false
.then, plan works in the 2 PR without any lock.
Closes #1391