Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow --gh-team-allowlist to work with team names and slugs #2719

Merged
merged 4 commits into from
Nov 25, 2022
Merged

Allow --gh-team-allowlist to work with team names and slugs #2719

merged 4 commits into from
Nov 25, 2022

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Nov 25, 2022 •
edited
Loading

@nitrocode nitrocode added needs discussion Large change that needs review from community/maintainers needs tests Change requires tests labels Nov 25, 2022
@nitrocode nitrocode marked this pull request as ready for review November 25, 2022 16:58
@nitrocode nitrocode requested a review from a team as a code owner November 25, 2022 16:58
@nitrocode nitrocode removed the needs tests Change requires tests label Nov 25, 2022
@nitrocode
Copy link
Member Author

cc: @paulerickson @albertorm95 @jamengual @msarvar @nishkrishnan (previous PR reviewers of #1694) if you folks could look this over too, that would help.

cc: @keitap @dversoza (PR authors of docs to mention using team name instead of slug)

@nitrocode nitrocode added quick-win Is obviously something Atlantis should do and will take <4 hrs work waiting-on-review Waiting for a review from a maintainer bug Something isn't working labels Nov 25, 2022
@nitrocode nitrocode removed needs discussion Large change that needs review from community/maintainers waiting-on-review Waiting for a review from a maintainer labels Nov 25, 2022
@nitrocode nitrocode merged commit 629e688 into main Nov 25, 2022
@nitrocode nitrocode deleted the team-slugs branch November 25, 2022 18:47
krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
@nitrocode @krrrr38
Allow --gh-team-allowlist to work with team names and slugs (runatl…
412eea6 
…antis#2719)

* Add team slugs

* Expand test to include both names and slugs

* docs: add version document of flag before/after

* docs: this will be merged for next release
@nitrocode nitrocode added this to the 0.21.0 milestone Jan 13, 2023
@albertorm95 albertorm95 mentioned this pull request May 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

Assignees
No one assigned
Labels
bug Something isn't working quick-win Is obviously something Atlantis should do and will take <4 hrs work
Projects
None yet
Milestone
v0.21.0
Development

Successfully merging this pull request may close these issues.

Allow --gh-team-allowlist to work with team names and slugs
2 participants
@nitrocode @jamengual