Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add example how to customize the conftest command #2727

Merged
merged 7 commits into from
Dec 7, 2022

Conversation

pokgak
Copy link
Contributor

@pokgak pokgak commented Nov 26, 2022

following up from this thread: https://atlantis-community.slack.com/archives/C5MGGAV0C/p1668413216626419

  • mention conftest --update flag to pull policies from remote sources
  • add example how to customize conftest command to be able to run policy checks against Terraform (*.tf) files

@jamengual
Copy link
Contributor

Thanks for the contribution @pokgak

@nitrocode
Copy link
Member

I added some comments. Thank you so much for the contribution!

@nitrocode nitrocode added the docs Documentation label Nov 26, 2022
@pokgak
Copy link
Contributor Author

pokgak commented Nov 27, 2022

Updated the PR. Thanks for the review @nitrocode @jamengual.

@pokgak
Copy link
Contributor Author

pokgak commented Nov 27, 2022

Not sure why the links check failed. I don't have issues accessing all the URLs when I copy pasted them to my browser.

@nitrocode
Copy link
Member

I don't understand why but the tests are failing because it thinks the following link returns a 403

https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_examples_s3_rw-bucket.html

Copy link
Member

@nitrocode nitrocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets remove the url that is causing the ci issues

@pokgak
Copy link
Contributor Author

pokgak commented Nov 30, 2022

@nitrocode it seems like right now the link tests still fail, now due to links that already existed before from pages that I didn't touch in this PR.

@nitrocode
Copy link
Member

The ci script runs across the entire source code, not just in the files affected by the pr.

https://github.com/runatlantis/atlantis/blob/main/.circleci/config.yml

Other prs have passing tests so I'm unsure why this is happening.

cc @runatlantis/maintainers what do you folks think?

@pokgak
Copy link
Contributor Author

pokgak commented Dec 7, 2022

Looks like the link tests passes now after the merge.

@pokgak pokgak requested a review from nitrocode December 7, 2022 03:24
@nitrocode nitrocode merged commit fe207ae into runatlantis:main Dec 7, 2022
@nitrocode
Copy link
Member

Thank you @pokgak for being patient with us while we fixed the test issues. Please feel free to contribute more documentation PRs. I'm sure the next one will be much faster.

krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
…2727)

* docs: add example how to customize the conftest command

* fixed PR review comments

* rerun CI

* remove problematic url

Co-authored-by: nitrocode <[email protected]>
Co-authored-by: PePe Amengual <[email protected]>
@nitrocode nitrocode added this to the 0.22.0 milestone Dec 23, 2022
@albertorm95
Copy link
Contributor

albertorm95 commented Mar 21, 2024

Do this still works?
add example how to customize conftest command to be able to run policy checks against Terraform (*.tf) files

I'm getting unable to unmarshal conftest output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants