-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add example how to customize the conftest command #2727
Conversation
Thanks for the contribution @pokgak |
I added some comments. Thank you so much for the contribution! |
Updated the PR. Thanks for the review @nitrocode @jamengual. |
Not sure why the links check failed. I don't have issues accessing all the URLs when I copy pasted them to my browser. |
I don't understand why but the tests are failing because it thinks the following link returns a 403 https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_examples_s3_rw-bucket.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets remove the url that is causing the ci issues
@nitrocode it seems like right now the link tests still fail, now due to links that already existed before from pages that I didn't touch in this PR. |
The ci script runs across the entire source code, not just in the files affected by the pr. https://github.com/runatlantis/atlantis/blob/main/.circleci/config.yml Other prs have passing tests so I'm unsure why this is happening. cc @runatlantis/maintainers what do you folks think? |
Looks like the link tests passes now after the merge. |
Thank you @pokgak for being patient with us while we fixed the test issues. Please feel free to contribute more documentation PRs. I'm sure the next one will be much faster. |
…2727) * docs: add example how to customize the conftest command * fixed PR review comments * rerun CI * remove problematic url Co-authored-by: nitrocode <[email protected]> Co-authored-by: PePe Amengual <[email protected]>
Do this still works? I'm getting |
following up from this thread: https://atlantis-community.slack.com/archives/C5MGGAV0C/p1668413216626419
--update
flag to pull policies from remote sources*.tf
) files