bugfix: Metrics initialization

[Fabianoshz]

what

• Adds empty metrics for prometheus when starting the server.

why

• Prevent NaN from showing up for metrics when atlantis first starts

references

• Closes Initialize Atlantis metrics with zeroes #2652

[Fabianoshz]

Please tell me if adding the NewInstrumentedProjectCommandRunner is a good idea here, this would be the way to go in other languages but I'm not so sure if this is a good pattern when using golang. I'm also aware that the code can be simplified and more organized, just scrambled this to start from somewhere (should have explained that in the initially, sorry 😅)

[jamengual]

Please tell me if adding the NewInstrumentedProjectCommandRunner is a good idea here, this would be the way to go in other languages but I'm not so sure if this is a good pattern when using golang. I'm also aware that the code can be simplified and more organized, just scrambled this to start from somewhere (should have explained that in the initially, sorry 😅)

hard to know about the name since in the same file there is some sort of a pattern but then the is another function that does not follow the same name pattern.... @nitrocode @lilincmu what do you guys think?

[Fabianoshz]

Made some changes to make this code look a little more like instrumented_pull_closed_executor file, my idea is to have something between the functions and the struct creation on the server/server.go where I would be able to initialize the metrics, in this case the NewInstrumentedProjectCommandRunner. For the other instrumented it would be their respective NewInstrumentedSomething.

I was forced to implement the function ApprovePolicies, otherwise NewApprovePoliciesCommandRunner would break on server/server.go:

atlantis/server/server.go

Lines 682 to 690 in 4d95783

	approvePoliciesCommandRunner := events.NewApprovePoliciesCommandRunner(
	commitStatusUpdater,
	projectCommandBuilder,
	instrumentedProjectCmdRunner,
	pullUpdater,
	dbUpdater,
	userConfig.SilenceNoProjects,
	userConfig.SilenceVCSStatusNoPlans,
	)

It's not clear to me why this is necessary.

[Fabianoshz]

Made some mess with git here, sorry. Anyway, added the same logic for the other instrumented which I believe would be the places where this initialization would be applicable.

[nitrocode]

cc @albertorm95 for an extra set of eyes

[GenPage]

A function inside of the metrics package also makes sense to me. Thank you for taking the time to do this @Fabianoshz

[albertorm95]

Looks good to me.

Can you share how it looks in the /metrics endpoint? (I mean the metrics with the 0 value)

• Initialize Atlantis metrics with zeroes #2652 (comment)

[Fabianoshz]

I will add the function and move this out of draft later today.