Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(changelog): explicitly list the tf versions <1.x removal in the CHANGELOG.md #2780

Conversation

NitriKx
Copy link
Contributor

@NitriKx NitriKx commented Dec 12, 2022

what

  • Explicitly write the old Terraform versions removal as a breaking change in the CHANGELOG

why

  • I've been surprised by this during upgrade to v0.21

references

@NitriKx NitriKx requested a review from a team as a code owner December 12, 2022 14:47
Copy link
Member

@nitrocode nitrocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @jamengual what do you think?

@nitrocode
Copy link
Member

nitrocode commented Dec 12, 2022

@NitriKx what was the result from atlantis removing the old tf versions? Were your selected version not auto downloaded by atlantis?

@GenPage
Copy link
Member

GenPage commented Dec 12, 2022

@nitrocode This is a good thing to point out if people are relying on the functionality. LGTM

@NitriKx
Copy link
Contributor Author

NitriKx commented Dec 12, 2022

@nitrocode the thing is that we use terragrunt in top of terraform and we have additional scripts in the workflow that selects the right version to use. We are planning to use auto-download feature to be able to update to v0.21.
Thanks for the review

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@nitrocode nitrocode merged commit db9f022 into runatlantis:main Dec 13, 2022
@NitriKx NitriKx deleted the nitrikx-update-changelog-drop-old-terraform-versions branch December 13, 2022 09:21
krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
…CHANGELOG.md (runatlantis#2780)

* docs(changelog): explicitly list the tf versions <1.x removal in the CHANGELOG.md

* Apply suggestions from code review

Co-authored-by: nitrocode <[email protected]>
@nitrocode nitrocode added this to the 0.22.0 milestone Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants