tests: e2e test to use conftest command instead version-specific command #2851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krrrr38
commented
Dec 22, 2022
| conftextExec := policy.NewConfTestExecutorWorkflow(logger, binDir, &NoopTFDownloader{}) | ||
|
|
||
| // swapping out version cache to something that always returns local contest | ||
| // binary | ||
| conftextExec.VersionCache = &LocalConftestCache{} | ||
|
|
||
| policyCheckRunner, err := runtime.NewPolicyCheckStepRunner( | ||
| conftestVersion, | ||
| defaultTFVersion, |
There was a problem hiding this comment.
asis impl is invalid. runtime.NewPolicyCheckStepRunner first parameter is defaultTfVersion.
krrrr38
commented
Dec 22, 2022
| func (m *LocalConftestCache) Get(key *version.Version) (string, error) { | ||
| return exec.LookPath(fmt.Sprintf("conftest%s", ConftestVersion)) | ||
| func (m *LocalConftestCache) Get(_ *version.Version) (string, error) { | ||
| return exec.LookPath(conftestCommand) |
There was a problem hiding this comment.
This is a main change in this PR. In e2e test, use conftest command.
krrrr38
force-pushed
the
refactor-e2e-no-conftest-version-dependency
branch
from
408e587
to
bc595ce
Compare
krrrr38
force-pushed
the
refactor-e2e-no-conftest-version-dependency
branch
from
bc595ce
to
3862f45
Compare
krrrr38
force-pushed
the
refactor-e2e-no-conftest-version-dependency
branch
from
3862f45
to
07c9de0
Compare
nitrocode
approved these changes
Dec 22, 2022
nitrocode
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
conftestcommand insteadconftest$versioncommand in the e2e testconftestcommand if version is not specifiedwhy
discussion
conftest$versioncommand on Dockerfile.conftestand Dockerfile useconftest$version.references
conftestbinary fail with newer versions of the utility #2600