chore(deps): Upgrade gopkg.in/yaml to v3

[nitrocode]

what

• Upgrade gopkg.in/yaml to v3 (may 2022)
• Deprecate v2 (nov 2020)

why

• Use latest and greatest

references

• Closes fix(deps): update module gopkg.in/yaml.v2 to v3 in go.mod #2861
• https://gopkg.in/yaml.v3
• https://github.com/go-yaml/yaml/tree/v3.0.1
• go-yaml/yaml@v2.4.0...v3.0.1
• Related issue v3: Feature Request: Decoder/Encoder Options go-yaml/yaml#639
• Related issue v2 to v3 migration guide?  go-yaml/yaml#863
• Related issue gcp (and snyk) container scan output #2883

notes

• From the related issues, this seems like a difficult and error-prone upgrade. I do not think it's worth it at this time since this may introduce other issues.
• current errors are below

--- FAIL: TestPolicySetsConfig_YAMLMarshalling (0.00s)
    --- FAIL: TestPolicySetsConfig_YAMLMarshalling/valid_yaml (0.00s)
        policies_test.go:61: unexpected error: EOF
--- FAIL: TestProject_UnmarshalYAML (0.00s)
    --- FAIL: TestProject_UnmarshalYAML/omit_unset_fields (0.00s)
        project_test.go:81: unexpected error: EOF
--- FAIL: TestConfig_UnmarshalYAML (0.00s)
    --- FAIL: TestConfig_UnmarshalYAML/no_data (0.00s)
        repo_cfg_test.go:197: unexpected error: EOF
--- FAIL: TestStage_UnmarshalYAML (0.00s)
    --- FAIL: TestStage_UnmarshalYAML/empty (0.00s)
        stage_test.go:48: unexpected error: EOF
--- FAIL: TestStepConfig_YAMLMarshalling (0.00s)
    --- FAIL: TestStepConfig_YAMLMarshalling/single_string (0.00s)
        step_test.go:174: unexpected error: EOF
    --- FAIL: TestStepConfig_YAMLMarshalling/extra_args_style (0.00s)
        step_test.go:174: unexpected error: EOF
    --- FAIL: TestStepConfig_YAMLMarshalling/extra_args_style_multiple_keys (0.00s)
        step_test.go:174: unexpected error: EOF
    --- FAIL: TestStepConfig_YAMLMarshalling/extra_args_style_multiple_top-level_keys (0.00s)
        step_test.go:174: unexpected error: EOF
    --- FAIL: TestStepConfig_YAMLMarshalling/env_step_value (0.00s)
        step_test.go:174: unexpected error: EOF
    --- FAIL: TestStepConfig_YAMLMarshalling/env_step_command (0.00s)
        step_test.go:174: unexpected error: EOF
    --- FAIL: TestStepConfig_YAMLMarshalling/run_step (0.00s)
        step_test.go:174: unexpected error: EOF
    --- FAIL: TestStepConfig_YAMLMarshalling/run_step_multiple_top-level_keys (0.00s)
        step_test.go:174: unexpected error: EOF
    --- FAIL: TestStepConfig_YAMLMarshalling/empty (0.00s)
        step_test.go:166: unexpected error: EOF
--- FAIL: TestWorkflowHook_YAMLMarshalling (0.00s)
    --- FAIL: TestWorkflowHook_YAMLMarshalling/run_step (0.00s)
        workflow_step_test.go:73: unexpected error: EOF
    --- FAIL: TestWorkflowHook_YAMLMarshalling/run_step_multiple_top-level_keys (0.00s)
        workflow_step_test.go:73: unexpected error: EOF
--- FAIL: TestWorkflow_UnmarshalYAML (0.00s)
    --- FAIL: TestWorkflow_UnmarshalYAML/empty (0.00s)
        workflow_test.go:117: unexpected error: EOF

[nitrocode]

Looks like this is breaking tests so additional fixes will have to be put in to ensure this doesn't break anything.

[nitrocode]

@krrrr38 From the related issues, this seems like a difficult and error-prone upgrade. I do not think it's worth it at this time since this may introduce other issues.

Interested in your thoughts here.

[krrrr38]

There are many changes from v2 to v3 upgrading https://ubuntu.com/blog/api-v3-of-the-yaml-package-for-go-is-available. v2.4.0 is 2years old lib, so it is better to upgrade in the not so far future.

No needed to upgrade urgently. So, how about to upgrade go-yaml v3 in the atlantis v0.23.0 or 0.22.1? After releasing 0.22.0, we will soon merge go-yaml v3 to provide dev/pre-release image to users for checking behaviour.

[nitrocode]

@krrrr38 feel free to try the upgrade. I may be using the new library incorrectly. From the issues in the upstream library, I'm hesitant to upgrade because there are a lot of v3 bugs so I figured this migration may give us a higher ROI once v3 is more stable. The bugs keep getting written and the commits have unfortunately stalled in that repo...

[nitrocode]

Tests are magically passing due to a paths bug triggering the no op action

[GenPage]

I've been digging into the test failures, it seems to be related to how v3 now handles null values

[jamengual]

@nitrocode do you think you will have time to finish this?

[jamengual]

@nitrocode is this still relevant?