Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(command_parser): help text to use executable command #2878

Merged
merged 1 commit into from
Dec 25, 2022
Merged

fix(command_parser): help text to use executable command #2878

merged 1 commit into from
Dec 25, 2022

Conversation

marcusramberg
Copy link
Contributor

@marcusramberg marcusramberg commented Dec 25, 2022 •
edited by nitrocode
Loading

what

why

  • If the executable is not Atlantis it's confusing for the help text to show atlantis as the executable.

references

@marcusramberg marcusramberg requested a review from a team as a code owner December 25, 2022 09:54
@marcusramberg marcusramberg changed the title fix(command_parser): Update command parser help test to use the new customizable executable command fix(command_parser): Update command parser help text to use the new customizable executable command Dec 25, 2022
@marcusramberg
fix(command_parser): Update command parser help text
1988a97 
Change it to use the new customizable executable command
nitrocode
nitrocode approved these changes Dec 25, 2022
View reviewed changes
Copy link
Member

@nitrocode nitrocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thank you for the contribution.

@nitrocode nitrocode changed the title fix(command_parser): Update command parser help text to use the new customizable executable command fix(command_parser): help text to use executable command Dec 25, 2022
@nitrocode nitrocode merged commit de953fe into runatlantis:main Dec 25, 2022
@nitrocode nitrocode added this to the 0.22.0 milestone Dec 26, 2022
@albertorm95 albertorm95 mentioned this pull request May 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.22.0
Development

Successfully merging this pull request may close these issues.
2 participants
@marcusramberg @nitrocode