Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): add vulnerability codeql scanning #2879

Merged
merged 2 commits into from
Jan 16, 2023
Merged

feat(build): add vulnerability codeql scanning #2879

merged 2 commits into from
Jan 16, 2023

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Dec 25, 2022

@nitrocode nitrocode requested a review from a team as a code owner December 25, 2022 20:08
@jamengual jamengual added the dependencies PRs that update a dependency file label Dec 29, 2022
@nitrocode nitrocode changed the title Add vulnerability codeql scanning feat(build): Add vulnerability codeql scanning Jan 16, 2023
@nitrocode nitrocode changed the title feat(build): Add vulnerability codeql scanning feat(build): add vulnerability codeql scanning Jan 16, 2023
Copy link
Contributor

@krrrr38 krrrr38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/workflows/codeql.yml Show resolved Hide resolved
Copy link
Contributor

@jamengual jamengual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as long as this work based on the files included on PRs and not the whole project then it LGTM.

@jamengual
Copy link
Contributor

LGTM

BTW/FYI we cannot see this url. https://github.com/runatlantis/atlantis/security/code-scanning?query=pr%3A2879+tool%3ACodeQL+is%3Aopen

I can see it, maybe this need to be setup as repo level.

@nitrocode
Copy link
Member Author

BTW/FYI we cannot see this url. https://github.com/runatlantis/atlantis/security/code-scanning?query=pr%3A2879+tool%3ACodeQL+is%3Aopen

@krrrr38 Perhaps only maintainers can see this? I created this ticket for now and i expand on it if you'd like to work on it #2884.

@jamengual since we have the associated ticket. We can dismiss the current issues as non-issues (even tho they are real issues) and associate the ticket in the message. Then we can merge this with passing pr checks so future prs that are contributed will pass or fail depending on the contributed code.

@nitrocode nitrocode merged commit bcbcf5c into main Jan 16, 2023
@nitrocode nitrocode deleted the codeql branch January 16, 2023 21:53
@nitrocode nitrocode added this to the v0.22.3 milestone Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies PRs that update a dependency file security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants