-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: markdown renderer use ExecutableName instead atlantis #2939
fix: markdown renderer use ExecutableName instead atlantis #2939
Conversation
e6d3953
to
b8f1aae
Compare
cmd/server_test.go
Outdated
@@ -57,7 +57,7 @@ var testFlags = map[string]interface{}{ | |||
ADWebhookPasswordFlag: "ad-wh-pass", | |||
ADWebhookUserFlag: "ad-wh-user", | |||
AtlantisURLFlag: "url", | |||
AllowCommandsFlag: "version,plan,unlock,import,approve_policies", // apply is disabled by DisableApply | |||
AllowCommandsFlag: "version,plan,unlock,import,approve_policies", // apply is disabled by disableApply |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we keep this all lowercase for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nitrocode reverted these changes. now ready for review 🙇
@krrrr38 I had one comment and I noticed that tests are failing. |
Thank you @krrrr38 ! |
what
why
When using
--executable-name=atlantis-dev
, some messages still containatlantis
.tests
before
after
references
n/a