Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: markdown renderer use ExecutableName instead atlantis #2939

Merged
merged 6 commits into from
Jan 6, 2023

Conversation

krrrr38
Copy link
Contributor

@krrrr38 krrrr38 commented Jan 6, 2023

what

why

When using --executable-name=atlantis-dev, some messages still contain atlantis.

貼り付けた画像_2023_01_07_5_52

tests

  • existed tests keep success
  • check all atlantis words are replaced like followings

before

✘╹◡╹✘☆  ag "\`atlantis" server/events/templates/
server/events/templates/multi_project_plan.tmpl
8:    * `atlantis apply`
10:    * `atlantis unlock`{{end}}{{end}}{{ template "log" . }}

server/events/templates/unwrapped_err.tmpl
7:    * `atlantis approve_policies`

server/events/templates/single_project_plan_success.tmpl
8:    * `atlantis apply`
10:    * `atlantis unlock`{{ end }}{{ template "log" . }}

after

✘╹◡╹✘☆  ag "atlantis" server/events/templates/ | wc -l
       0

references

n/a

@krrrr38 krrrr38 requested a review from a team as a code owner January 6, 2023 20:56
@@ -57,7 +57,7 @@ var testFlags = map[string]interface{}{
ADWebhookPasswordFlag: "ad-wh-pass",
ADWebhookUserFlag: "ad-wh-user",
AtlantisURLFlag: "url",
AllowCommandsFlag: "version,plan,unlock,import,approve_policies", // apply is disabled by DisableApply
AllowCommandsFlag: "version,plan,unlock,import,approve_policies", // apply is disabled by disableApply
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we keep this all lowercase for now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nitrocode reverted these changes. now ready for review 🙇

nitrocode
nitrocode previously approved these changes Jan 6, 2023
@nitrocode nitrocode dismissed their stale review January 6, 2023 22:09

tests failing

@nitrocode
Copy link
Member

@krrrr38 I had one comment and I noticed that tests are failing.

@nitrocode nitrocode merged commit 46bf046 into runatlantis:main Jan 6, 2023
@nitrocode
Copy link
Member

Thank you @krrrr38 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants